Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

FilesInfos InfosWarnings WarningsErrors Errors
45161810

Files

FilesI InfosW WarningsE Errors
org/jage/platform/component/IStatefulComponent.java030
org/jage/platform/component/annotation/AutowiredPropertiesFactory.java020
org/jage/platform/component/annotation/AutowiredPropertiesReader.java050
org/jage/platform/component/annotation/Inject.java020
org/jage/platform/component/annotation/Require.java010
org/jage/platform/component/builder/AbstractBuilder.java5170
org/jage/platform/component/builder/ArrayBuilder.java220
org/jage/platform/component/builder/CollectionBuilder.java220
org/jage/platform/component/builder/ComponentBuilder.java230
org/jage/platform/component/builder/ConfigurationBuilder.java0180
org/jage/platform/component/builder/IConfigurationBuilder.java0170
org/jage/platform/component/builder/MapBuilder.java250
org/jage/platform/component/contract/xml/StructXmlBuilder.java1260
org/jage/platform/component/definition/AbstractComponentDefinition.java020
org/jage/platform/component/definition/ComponentDefinition.java020
org/jage/platform/component/definition/Configuration.java050
org/jage/platform/component/definition/ConfigurationException.java040
org/jage/platform/component/definition/IConfigurator.java030
org/jage/platform/component/definition/ISingleValueProvider.java020
org/jage/platform/component/definition/IValueCollectionProvider.java020
org/jage/platform/component/definition/MapDefinition.java040
org/jage/platform/component/definition/PropertyInitializer.java060
org/jage/platform/component/definition/ReferenceCollectionProvider.java020
org/jage/platform/component/definition/ReferenceProvider.java030
org/jage/platform/component/definition/SimpleTypeParsers.java1140
org/jage/platform/component/descriptor/ComponentDescriptorReader.java140
org/jage/platform/component/exception/ComponentException.java090
org/jage/platform/component/provider/IComponentInstanceProvider.java010
org/jage/platform/component/provider/IComponentInstanceProviderAware.java030
org/jage/platform/component/provider/IMutableComponentInstanceProvider.java070
org/jage/platform/component/provider/IMutableComponentInstanceProviderAware.java030
org/jage/platform/component/provider/ISelfAwareComponentInstanceProviderAware.java020

Rules

RulesViolationsSeverity
AbstractClassName1Infos Info
ConstantName2Warnings Warning
LocalFinalVariableName0Warnings Warning
LocalVariableName
  • tokens: "PARAMETER_DEF,VARIABLE_DEF"
0Warnings Warning
MemberName3Warnings Warning
MethodName46Warnings Warning
PackageName
  • format: "^org\.jage(\.[a-z][a-z0-9]*)*$"
0Warnings Warning
ParameterName0Warnings Warning
StaticVariableName0Warnings Warning
TypeName0Warnings Warning
AvoidStarImport0Warnings Warning
IllegalImport0Warnings Warning
RedundantImport0Warnings Warning
UnusedImports2Warnings Warning
ImportOrder
  • separated: "true"
  • groups: "java,javax,org,org.jage"
4Warnings Warning
LineLength
  • max: "140"
  • tabWidth: "4"
2Warnings Warning
MethodLength
  • tokens: "CTOR_DEF,METHOD_DEF"
0Warnings Warning
AnonInnerLength
  • max: "50"
0Warnings Warning
ParameterNumber
  • tokens: "CTOR_DEF,METHOD_DEF"
0Warnings Warning
MethodParamPad0Warnings Warning
NoWhitespaceAfter
  • tokens: "LNOT,DOT,BNOT,DEC,UNARY_MINUS,UNARY_PLUS,INC,TYPECAST"
6Warnings Warning
NoWhitespaceBefore
  • allowLineBreaks: "true"
  • tokens: "SEMI,DOT,POST_DEC,POST_INC"
0Warnings Warning
OperatorWrap
  • tokens: "COLON,NOT_EQUAL,QUESTION,DIV,BXOR,MINUS,STAR,BAND,LAND,MOD,PLUS,LT,SL,LE,EQUAL,GT,GE,SR,BSR,BOR,LOR,LITERAL_INSTANCEOF"
0Warnings Warning
ParenPad
  • tokens: "LPAREN,RPAREN,CTOR_CALL,METHOD_CALL,SUPER_CTOR_CALL"
1Warnings Warning
TypecastParenPad
  • tokens: "RPAREN,TYPECAST"
0Warnings Warning
WhitespaceAfter
  • tokens: "COMMA,SEMI"
7Warnings Warning
ModifierOrder1Warnings Warning
AvoidNestedBlocks
  • allowInSwitchCase: "true"
0Warnings Warning
EmptyBlock
  • tokens: "LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,STATIC_INIT,LITERAL_TRY,LITERAL_WHILE"
0Warnings Warning
LeftCurly
  • maxLineLength: "120"
  • tokens: "LITERAL_CATCH,CLASS_DEF,CTOR_DEF,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,INTERFACE_DEF,METHOD_DEF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE"
0Warnings Warning
NeedBraces
  • tokens: "LITERAL_DO,LITERAL_ELSE,LITERAL_FOR,LITERAL_IF,LITERAL_WHILE"
4Warnings Warning
RightCurly
  • tokens: "LITERAL_CATCH,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_IF,LITERAL_TRY"
0Warnings Warning
AvoidInlineConditionals0 Ignore
DoubleCheckedLocking0Errors Error
EmptyStatement0Errors Error
EqualsHashCode0Errors Error
HiddenField
  • ignoreAbstractMethods: "true"
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
4Warnings Warning
InnerAssignment
  • tokens: "DIV_ASSIGN,BXOR_ASSIGN,STAR_ASSIGN,BAND_ASSIGN,MOD_ASSIGN,PLUS_ASSIGN,SL_ASSIGN,ASSIGN,MINUS_ASSIGN,SR_ASSIGN,BSR_ASSIGN,BOR_ASSIGN"
0Warnings Warning
MagicNumber0 Ignore
MissingSwitchDefault0Warnings Warning
ModifiedControlVariable0Warnings Warning
RedundantThrows
  • allowUnchecked: "true"
0Warnings Warning
SimplifyBooleanExpression0Warnings Warning
SimplifyBooleanReturn0Warnings Warning
StringLiteralEquality0Errors Error
NestedIfDepth
  • max: "3"
0Warnings Warning
NestedTryDepth
  • max: "2"
0Warnings Warning
SuperClone0 Ignore
SuperFinalize0Warnings Warning
IllegalCatch2Infos Info
IllegalThrows0Infos Info
PackageDeclaration0Warnings Warning
DefaultComesLast0Warnings Warning
FallThrough
  • checkLastCaseGroup: "true"
0Warnings Warning
MultipleStringLiterals11Warnings Warning
UnnecessaryParentheses0Warnings Warning
DeclarationOrder0 Ignore
FinalClass0Warnings Warning
HideUtilityClassConstructor0 Ignore
VisibilityModifier0 Ignore
ThrowsCount
  • max: "3"
0Infos Info
ArrayTypeStyle0Warnings Warning
RegexpSinglelineJava
  • message: "Line has trailing spaces."
  • ignoreComments: "true"
  • format: "\s+$"
4Warnings Warning
TodoComment0 Ignore
UncommentedMain0Warnings Warning
UpperEll0Warnings Warning
Indentation4Warnings Warning
JavadocType
  • scope: "package"
0Errors Error
JavadocType25Warnings Warning
JavadocMethod
  • allowMissingPropertyJavadoc: "true"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowUndeclaredRTE: "true"
  • tokens: "CTOR_DEF,METHOD_DEF"
  • allowMissingThrowsTags: "true"
38Warnings Warning
JavadocVariable
  • scope: "package"
1Warnings Warning
JavadocStyle
  • scope: "public"
  • checkEmptyJavadoc: "true"
13Warnings Warning
JavadocType
  • authorFormat: "AGH AgE Team"
25Warnings Warning
EmptyForInitializerPad
  • option: "space"
0Infos Info
EmptyForIteratorPad0Infos Info
MethodParamPad
  • tokens: "CTOR_DEF,METHOD_CALL,METHOD_DEF,LITERAL_NEW,SUPER_CTOR_CALL"
0Warnings Warning
CovariantEquals0Warnings Warning
IllegalType
  • tokens: "METHOD_DEF,PARAMETER_DEF,VARIABLE_DEF"
0 Ignore
MultipleVariableDeclarations0Warnings Warning
ParameterAssignment3Warnings Warning
ReturnCount
  • max: "3"
  • format: "^equals$"
0Warnings Warning
TrailingComment0 Ignore
JavadocMethod
  • allowMissingParamTags: "true"
  • allowMissingPropertyJavadoc: "true"
  • allowThrowsTagsForSubclasses: "true"
  • excludeScope: "protected"
  • scope: "package"
  • allowUndeclaredRTE: "true"
  • tokens: "CTOR_DEF,METHOD_DEF"
  • allowMissingReturnTag: "true"
  • allowMissingThrowsTags: "true"
13Infos Info
RegexpHeader
  • headerFile: "target/checkstyle-header.txt"
14Warnings Warning
NewlineAtEndOfFile
  • lineSeparator: "lf"
  • fileExtensions: "java,properties,xml"
0Warnings Warning
Translation0Errors Error
JavadocPackage
  • allowLegacy: "true"
5Warnings Warning
FileLength0Warnings Warning

Details

org/jage/platform/component/IStatefulComponent.java

ViolationMessageLine
WarningsMissing package-info.java file.0
WarningsLine does not match expected header line of '^ \* Created: \d\d\d\d-\d\d-\d\d$'.28
WarningsJavadoc has empty description section.37

org/jage/platform/component/annotation/AutowiredPropertiesFactory.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsMissing a Javadoc comment.43

org/jage/platform/component/annotation/AutowiredPropertiesReader.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsMissing a Javadoc comment.37
Warnings',' is not followed by whitespace.58
WarningsLine is longer than 140 characters.70
WarningsThe String "Readable autowired properties are currently not supported" appears 2 times in the file.71

org/jage/platform/component/annotation/Inject.java

ViolationMessageLine
WarningsWrong order for 'java.lang.annotation.Documented' import.40
Warnings'(' is followed by whitespace.54

org/jage/platform/component/annotation/Require.java

ViolationMessageLine
WarningsWrong order for 'java.lang.annotation.Documented' import.39

org/jage/platform/component/builder/AbstractBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsMissing a Javadoc comment.35
InfosMissing a Javadoc comment.39
InfosUnused @param tag for 'innerConfigurationBuilder'.57
InfosMissing a Javadoc comment.90
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.95
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.100
WarningsName 'Agent' must match pattern '^[a-z][a-zA-Z0-9]*$'.105
WarningsName 'Strategy' must match pattern '^[a-z][a-zA-Z0-9]*$'.110
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.115
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.120
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.125
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.130
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.135
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.140
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.145
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.150
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.155
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.160
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.165
InfosMissing a Javadoc comment.176
InfosMissing a Javadoc comment.180

org/jage/platform/component/builder/ArrayBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
InfosMissing a Javadoc comment.42
InfosMissing a Javadoc comment.51
Warnings'definition' hides a field.51

org/jage/platform/component/builder/CollectionBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
InfosMissing a Javadoc comment.42
InfosMissing a Javadoc comment.51
Warnings'definition' hides a field.51

org/jage/platform/component/builder/ComponentBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsMissing a Javadoc comment.32
InfosMissing a Javadoc comment.36
InfosMissing a Javadoc comment.45
Warnings'definition' hides a field.45

org/jage/platform/component/builder/ConfigurationBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsFirst sentence should end with a period.59
WarningsName 'Configuration' must match pattern '^[a-z][a-zA-Z0-9]*$'.63
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.68
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.75
WarningsName 'Agent' must match pattern '^[a-z][a-zA-Z0-9]*$'.80
WarningsName 'Strategy' must match pattern '^[a-z][a-zA-Z0-9]*$'.85
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.90
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.95
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.100
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.107
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.112
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.117
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.124
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.129
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.137
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.142
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.147

org/jage/platform/component/builder/IConfigurationBuilder.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsLine is longer than 140 characters.71
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.89
WarningsName 'Component' must match pattern '^[a-z][a-zA-Z0-9]*$'.100
WarningsName 'Agent' must match pattern '^[a-z][a-zA-Z0-9]*$'.111
WarningsName 'Strategy' must match pattern '^[a-z][a-zA-Z0-9]*$'.122
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.132
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.143
WarningsName 'Set' must match pattern '^[a-z][a-zA-Z0-9]*$'.156
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.166
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.177
WarningsName 'List' must match pattern '^[a-z][a-zA-Z0-9]*$'.190
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.201
WarningsName 'Array' must match pattern '^[a-z][a-zA-Z0-9]*$'.214
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.224
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.238
WarningsName 'Map' must match pattern '^[a-z][a-zA-Z0-9]*$'.253

org/jage/platform/component/builder/MapBuilder.java

ViolationMessageLine
WarningsMissing package-info.java file.0
WarningsLine does not match expected header line of '^/\*$'.26
InfosMissing a Javadoc comment.47
InfosMissing a Javadoc comment.56
Warnings'definition' hides a field.56
WarningsMissing a Javadoc comment.80
WarningsMissing a Javadoc comment.122

org/jage/platform/component/contract/xml/StructXmlBuilder.java

ViolationMessageLine
WarningsMissing package-info.java file.0
WarningsJavadoc has empty description section.60
WarningsType Javadoc tag @author must match pattern 'AGH AgE Team'.65
Warnings'if' construct must use '{}'s.76
Warnings'if' construct must use '{}'s.78
WarningsMissing a Javadoc comment.84
Warningsmethod def throws at indentation level 12 not at correct indentation, 885
WarningsAssignment of parameter 'dir' is not allowed.87
Warnings'if' construct must use '{}'s.114
WarningsThe String "class" appears 5 times in the file.131
WarningsThe String "version" appears 3 times in the file.133
Warnings'if' construct must use '{}'s.135
InfosCatching 'Exception' is not allowed.140
WarningsThe String "name" appears 2 times in the file.165
Warnings')' is followed by whitespace.182
WarningsThe String "array" appears 2 times in the file.195
WarningsThe String "dims" appears 2 times in the file.196
WarningsThe String "interface" appears 2 times in the file.204
WarningsThe String "special" appears 6 times in the file.207
WarningsThe String "list" appears 2 times in the file.207
WarningsThe String "set" appears 2 times in the file.209
WarningsThe String "map" appears 2 times in the file.211
Warnings')' is followed by whitespace.215
Warnings')' is followed by whitespace.216
Warnings')' is followed by whitespace.236
Warnings')' is followed by whitespace.242
Warnings')' is followed by whitespace.248

org/jage/platform/component/definition/AbstractComponentDefinition.java

ViolationMessageLine
WarningsMissing a Javadoc comment.129
WarningsMissing a Javadoc comment.133

org/jage/platform/component/definition/ComponentDefinition.java

ViolationMessageLine
WarningsWrong order for 'org.jage.property.IPropertyContainer' import.42
WarningsUnused import - org.jage.property.IPropertyContainer.42

org/jage/platform/component/definition/Configuration.java

ViolationMessageLine
WarningsMissing a Javadoc comment.39
WarningsName '_componentDefinitions' must match pattern '^[a-z][a-zA-Z0-9]*$'.41
WarningsMissing a Javadoc comment.43
WarningsMissing a Javadoc comment.47
WarningsMissing a Javadoc comment.51

org/jage/platform/component/definition/ConfigurationException.java

ViolationMessageLine
WarningsJavadoc has empty description section.35
WarningsMissing a Javadoc comment.43
WarningsMissing a Javadoc comment.47
WarningsMissing a Javadoc comment.51

org/jage/platform/component/definition/IConfigurator.java

ViolationMessageLine
WarningsType Javadoc tag @author must match pattern 'AGH AgE Team'.44
WarningsFirst sentence should end with a period.46
WarningsFirst sentence should end with a period.57

org/jage/platform/component/definition/ISingleValueProvider.java

ViolationMessageLine
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.48

org/jage/platform/component/definition/IValueCollectionProvider.java

ViolationMessageLine
WarningsMissing a Javadoc comment.47
WarningsMissing a Javadoc comment.49

org/jage/platform/component/definition/MapDefinition.java

ViolationMessageLine
WarningsMissing a Javadoc comment.111
WarningsName '_key' must match pattern '^[a-z][a-zA-Z0-9]*$'.112
WarningsName '_value' must match pattern '^[a-z][a-zA-Z0-9]*$'.114
WarningsMissing a Javadoc comment.116

org/jage/platform/component/definition/PropertyInitializer.java

ViolationMessageLine
WarningsWrong order for 'java.lang.String.format' import.44
WarningsMissing a Javadoc comment.51
WarningsName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.55
WarningsMissing a Javadoc comment.61
WarningsMissing a Javadoc comment.74
Warningsmethod def throws at indentation level 12 not at correct indentation, 875

org/jage/platform/component/definition/ReferenceCollectionProvider.java

ViolationMessageLine
WarningsMissing a Javadoc comment.40
WarningsMissing a Javadoc comment.48

org/jage/platform/component/definition/ReferenceProvider.java

ViolationMessageLine
WarningsMissing a Javadoc comment.37
WarningsFirst sentence should end with a period.48
WarningsFirst sentence should end with a period.65

org/jage/platform/component/definition/SimpleTypeParsers.java

ViolationMessageLine
WarningsLine does not match expected header line of '^/\*$'.26
WarningsMissing a Javadoc comment.32
WarningsName 'parsers' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.34
WarningsMissing a Javadoc comment.77
InfosName 'SimpleTypeParser' must match pattern '^Abstract.*$|^.*Factory$'.77
Warnings'public' modifier out of order with the JLS suggestions.80
WarningsMissing a Javadoc comment.83
WarningsMissing a Javadoc comment.91
WarningsMissing a Javadoc comment.103
WarningsMissing a Javadoc comment.115
WarningsMissing a Javadoc comment.127
WarningsMissing a Javadoc comment.139
WarningsMissing a Javadoc comment.151
WarningsMissing a Javadoc comment.163
WarningsMissing a Javadoc comment.171

org/jage/platform/component/descriptor/ComponentDescriptorReader.java

ViolationMessageLine
Warningsmethod def throws at indentation level 12 not at correct indentation, 883
InfosCatching 'Exception' is not allowed.98
WarningsAssignment of parameter 'descriptor' is not allowed.130
WarningsAssignment of parameter 'descriptor' is not allowed.134
Warningsmethod def throws at indentation level 12 not at correct indentation, 8149

org/jage/platform/component/exception/ComponentException.java

ViolationMessageLine
WarningsMissing package-info.java file.0
WarningsType Javadoc tag @author must match pattern 'AGH AgE Team'.40
WarningsJavadoc has empty description section.47
WarningsExpected @param tag for 'msg'.51
WarningsJavadoc has empty description section.56
WarningsExpected @param tag for 'e'.60
WarningsJavadoc has empty description section.65
WarningsExpected @param tag for 'message'.68
WarningsExpected @param tag for 'cause'.68

org/jage/platform/component/provider/IComponentInstanceProvider.java

ViolationMessageLine
WarningsUnused import - java.util.List.37

org/jage/platform/component/provider/IComponentInstanceProviderAware.java

ViolationMessageLine
WarningsType Javadoc tag @author must match pattern 'AGH AgE Team'.44
WarningsLine has trailing spaces.45
WarningsMissing a Javadoc comment.46

org/jage/platform/component/provider/IMutableComponentInstanceProvider.java

ViolationMessageLine
WarningsLine does not match expected header line of '^ \* Created: \d\d\d\d-\d\d-\d\d$'.28
WarningsJavadoc has empty description section.40
WarningsLine has trailing spaces.45
WarningsLine has trailing spaces.82
WarningsMissing a Javadoc comment.83
WarningsLine has trailing spaces.84
WarningsMissing a Javadoc comment.85

org/jage/platform/component/provider/IMutableComponentInstanceProviderAware.java

ViolationMessageLine
WarningsLine does not match expected header line of '^ \* Created: \d\d\d\d-\d\d-\d\d$'.28
WarningsJavadoc has empty description section.35
WarningsMissing a Javadoc comment.41

org/jage/platform/component/provider/ISelfAwareComponentInstanceProviderAware.java

ViolationMessageLine
WarningsMissing package-info.java file.0
WarningsLine does not match expected header line of '^ \* Created: \d\d\d\d-\d\d-\d\d$'.28