The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 396 | 44 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Write to static field pl.edu.agh.cast.dataview.Activator.plugin from instance method pl.edu.agh.cast.dataview.Activator.start(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 123 |
| Write to static field pl.edu.agh.cast.dataview.Activator.plugin from instance method pl.edu.agh.cast.dataview.Activator.stop(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 133 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Date to pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter$DateWithType in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.passFilter(Date, Date) | STYLE | BC_UNCONFIRMED_CAST | 100 |
| Call to method of static java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.convertFilterValue(String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 91 |
| Call to method of static java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.convertFilterValue(String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 87 |
| Call to method of static java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.convertFilterValue(String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 83 |
| Call to method of static java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.convertFilterValue(String) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 79 |
| Found static field of type java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.DAYS_FORMAT | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Found static field of type java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.HOURS_FORMAT | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Found static field of type java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.MINUTES_FORMAT | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Found static field of type java.text.DateFormat in pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter.SECONDS_FORMAT | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter$DateWithType is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | 65-73 |
| Should pl.edu.agh.cast.dataview.column.filter.impl.AbstractDateColumnFilter$DateWithType be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 65-73 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method pl.edu.agh.cast.dataview.column.provider.impl.DurationColumnValueProvider.getCellValue(IManyToManyRelation) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 34 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Call to method of static java.text.DateFormat in pl.edu.agh.cast.dataview.column.type.impl.DateColumnType.extractText(Date) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 45 |
| Found static field of type java.text.DateFormat in pl.edu.agh.cast.dataview.column.type.impl.DateColumnType.FORMAT | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method pl.edu.agh.cast.dataview.ui.ColumnFiltersController.removeAllFilters() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 82 |
| Bug | Category | Details | Line |
|---|---|---|---|
| DataTableColumnMenu.filterMenu not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| pl.edu.agh.cast.dataview.ui.DataTableLabelProvider.DataTableLabelProvider(DataViewColumn[]) may expose internal representation by storing an externally mutable object into DataTableLabelProvider.columns | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method pl.edu.agh.cast.dataview.ui.filter.NewFilterDialog.createComposite() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 125 |
| Bug | Category | Details | Line |
|---|---|---|---|
| pl.edu.agh.cast.dataview.util.Messages.BooleanColumnType_False isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.BooleanColumnType_True isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumnMenu_AddAlternative isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumnMenu_Remove isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumn_AddFilter isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumn_ClearFilters isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumn_FilterButtonTip isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumn_LabelEqualsFilter isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableColumn_NoFilters isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableEditor_FilterByValue isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableFilterDialog_DoFilter isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableFilterDialog_DoNegation isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableFilterDialog_FilterDesc isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableFilterDialog_FilterDialogText isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DataTableFilterDialog_FilterVal isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.DisjunctionColumnFilter_OR isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| pl.edu.agh.cast.dataview.util.Messages.NegationFilter_Negation isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| pl.edu.agh.cast.dataview.view.DataView.getColumns() may expose internal representation by returning DataView.columns | MALICIOUS_CODE | EI_EXPOSE_REP | 61 |
| pl.edu.agh.cast.dataview.view.DataView.DataView(String, IContentProvider, DataViewColumn[]) may expose internal representation by storing an externally mutable object into DataView.columns | MALICIOUS_CODE | EI_EXPOSE_REP2 | 57 |
| Method pl.edu.agh.cast.dataview.view.DataView.getColumns(IDataSet) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 98 |
| Bug | Category | Details | Line |
|---|---|---|---|
| pl.edu.agh.cast.dataview.view.DataViewColumnType.getFilters() may expose internal representation by returning DataViewColumnType.filters | MALICIOUS_CODE | EI_EXPOSE_REP | 63 |
| pl.edu.agh.cast.dataview.view.DataViewColumnType.DataViewColumnType(String, IComparator, ILabelProvider, DataViewColumnFilter[]) may expose internal representation by storing an externally mutable object into DataViewColumnType.filters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 57 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method pl.edu.agh.cast.dataview.view.util.ColumnTypes.readColumnFilters(IConfigurationElement) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 100 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method pl.edu.agh.cast.dataview.view.util.DataViewFactory.readDataViewColumns(IConfigurationElement) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 107 |