The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Low
Effort is Default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
610 | 88 | 0 | 0 |
Bug | Category | Details | Line |
---|---|---|---|
Write to static field pl.edu.agh.cast.schema.Activator.plugin from instance method pl.edu.agh.cast.schema.Activator.Activator() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 35 |
Write to static field pl.edu.agh.cast.schema.Activator.plugin from instance method pl.edu.agh.cast.schema.Activator.stop(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 53 |
Bug | Category | Details | Line |
---|---|---|---|
Class pl.edu.agh.cast.schema.action.OpenSchemaEditor implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 22-23 |
Bug | Category | Details | Line |
---|---|---|---|
SetLayoutAction._editor not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Unchecked/unconfirmed cast from pl.edu.agh.cast.model.visual.backward.IMoveable to pl.edu.agh.cast.model.visual.backward.Node in pl.edu.agh.cast.schema.command.MoveDiagramElementCommand.MoveDiagramElementCommand(IDiagram, IMoveable, Point, Point) | STYLE | BC_UNCONFIRMED_CAST | 37 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.command.SelectMediatorsCommand.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 29 |
SelectMediatorsCommand._changedNodes not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
The class pl.edu.agh.cast.schema.command.SetLayoutCommand$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 71-75 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.command.ToggleMainNodeCommand.ToggleMainNodeCommand(Node[]) may expose internal representation by storing an externally mutable object into ToggleMainNodeCommand._nodesToChange | MALICIOUS_CODE | EI_EXPOSE_REP2 | 25 |
Bug | Category | Details | Line |
---|---|---|---|
The class pl.edu.agh.cast.schema.editor.SchemaEditor$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 222-225 |
Bug | Category | Details | Line |
---|---|---|---|
The class pl.edu.agh.cast.schema.editor.SchemaEditor$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 226-229 |
Bug | Category | Details | Line |
---|---|---|---|
Should pl.edu.agh.cast.schema.editor.SchemaEditor$SchemaDiagramRunnable be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 90-103 |
Bug | Category | Details | Line |
---|---|---|---|
Unread field: pl.edu.agh.cast.schema.figure.DoublePolylineConnection.LinesDistance; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 35 |
Bug | Category | Details | Line |
---|---|---|---|
Should pl.edu.agh.cast.schema.figure.DoublePolylineConnection$InternalConnectionAnchor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 192-213 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to difference in pl.edu.agh.cast.schema.layout.algorithm.AbstractLayoutAlgorithm.layoutNodes(Collection, IProgressMonitor) | STYLE | DLS_DEAD_LOCAL_STORE | 63 |
Private method pl.edu.agh.cast.schema.layout.algorithm.AbstractLayoutAlgorithm.allNodesHavePositions(Collection) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 151-156 |
Bug | Category | Details | Line |
---|---|---|---|
AdvancedPeacockLayoutAlgorithm._nodesToPosition not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
AdvancedPeacockLayoutAlgorithm._notPositioned not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
AdvancedPeacockLayoutAlgorithm._positioned not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.CircleLayoutAlgorithm.setNodesPositions(Collection, IProgressMonitor) | STYLE | DLS_DEAD_LOCAL_STORE | 63 |
int division result cast to double or float in pl.edu.agh.cast.schema.layout.algorithm.CircleLayoutAlgorithm.setNodesPositions(Collection, IProgressMonitor) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 67 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.layout.algorithm.CombinationGenerator.getNext() may expose internal representation by returning CombinationGenerator._a | MALICIOUS_CODE | EI_EXPOSE_REP | 78 |
pl.edu.agh.cast.schema.layout.algorithm.CombinationGenerator.getNext() may expose internal representation by returning CombinationGenerator._a | MALICIOUS_CODE | EI_EXPOSE_REP | 91 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.displayFigureChildren(Collection, Node, List, int, int, double, double, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 180 |
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.setNodesPositions(Collection, IProgressMonitor) | STYLE | DLS_DEAD_LOCAL_STORE | 69 |
Method pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.getCycles(Collection, IProgressMonitor) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 103 |
Method pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.removeOneSingleNodes(Map, Node, List) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 150 |
Method pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.setNodesPositions(Collection, IProgressMonitor) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 53 |
int division result cast to double or float in pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.displayFigureChildren(Collection, Node, List, int, int, double, double, int, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 187 |
int division result cast to double or float in pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.setNodesPositions(Collection, IProgressMonitor) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 76 |
Method pl.edu.agh.cast.schema.layout.algorithm.GroupLayoutAlgorithm.getSingleEntities(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 127 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.NewPeacockLayoutAlgorithm.arrangeInArc(Collection, double, double, double, Point) | STYLE | DLS_DEAD_LOCAL_STORE | 96 |
int division result cast to double or float in pl.edu.agh.cast.schema.layout.algorithm.NewPeacockLayoutAlgorithm.arrangeInArc(Collection, double, double, double, Point) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 100 |
Bug | Category | Details | Line |
---|---|---|---|
Method pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.computeDistanceSums() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 527 |
Method pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.initNodesDistanceTables(List) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 477 |
java.lang.String is incompatible with expected argument type pl.edu.agh.cast.model.visual.backward.Node in pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.mergeGraphAndMakeTree(List) | CORRECTNESS | GC_UNRELATED_TYPES | 673 |
Method pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.getRootConnectionNodes(int, String) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 611 |
Method pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.mergeGraphAndMakeTree(List) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 662 |
pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.makeTree(Peacock3LayoutAlgorithm$TreeNode, Collection, List, List) ignores return value of java.util.Queue.offer(Object) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 411 |
pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.makeTree(Peacock3LayoutAlgorithm$TreeNode, Collection, List, List) ignores return value of java.util.Queue.offer(Object) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 425 |
pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.makeTree(Peacock3LayoutAlgorithm$TreeNode, Collection, List, List) ignores return value of java.util.Queue.offer(Object) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 437 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.ANGLE_RANGE_FACTOR; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 50 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.AREA_CENTER_X; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 38 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.AREA_CENTER_Y; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 40 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.DISTANCE_FACTOR; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 48 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.MAX_RADIUS_SCALE_FACTOR; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 46 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.MIN_RADIUS_SCALE_FACTOR; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 44 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.RADIUS_SCALE; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 42 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.STEPS_NUMBER; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 36 |
Method pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm.fillNodesDistanceTables(List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 501 |
Bug | Category | Details | Line |
---|---|---|---|
Should pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm$Edge be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 175-179 |
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm$Edge.weight | PERFORMANCE | URF_UNREAD_FIELD | 178 |
Bug | Category | Details | Line |
---|---|---|---|
Should pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm$TreeNode be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 85-95 |
Bug | Category | Details | Line |
---|---|---|---|
Unread field: pl.edu.agh.cast.schema.layout.algorithm.Peacock3LayoutAlgorithm$TreeNode.parent | PERFORMANCE | URF_UNREAD_FIELD | 434 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.PeacockLayoutAlgorithm.drawCommonEntities(List) | STYLE | DLS_DEAD_LOCAL_STORE | 178 |
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.PeacockLayoutAlgorithm.drawMainEntities(Collection) | STYLE | DLS_DEAD_LOCAL_STORE | 110 |
Dead store to location in pl.edu.agh.cast.schema.layout.algorithm.PeacockLayoutAlgorithm.drawTail(Node, Point, Collection) | STYLE | DLS_DEAD_LOCAL_STORE | 140 |
PeacockLayoutAlgorithm._bigRadiuses not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
PeacockLayoutAlgorithm._commonEntities not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
PeacockLayoutAlgorithm._mainEntities not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Unread field: pl.edu.agh.cast.schema.policy.SchemaConnectionCreatePolicy._propertyManager | PERFORMANCE | URF_UNREAD_FIELD | 32 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.AbstractLayoutAlgorithm_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.AbstractLayoutAlgorithm_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.AbstractLayoutAlgorithm_2 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.AbstractLayoutAlgorithm_3 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.ConnectionCreationCommand_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ConnectionTypeChangedAction_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ConnectionTypeChangedAction_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ConnectionTypeChangedAction_2 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.EnhancedCircleLayout_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.InvertSelectionAction_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.Peacock3LayoutAlgorithm_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ResetThicknessAction_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.SchemaEditorContextMenuProvider_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SchemaEditor_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SchemaEditor_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.SelectLeafNodesAction_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 46 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.SelectMediatorsCommand_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SelectRootNumbersAction_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SelectRootNumbersWizard_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SelectRootNumbersWizard_3 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SetConstraintCommand_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
pl.edu.agh.cast.schema.util.Messages.SetLayoutCommand_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ShowPropertiesAction isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 35 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ToggleMainEntityAction_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 31 |
Bug | Category | Details | Line |
---|---|---|---|
pl.edu.agh.cast.schema.util.Messages.ToggleMainEntityCommand_0 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available |
The field name pl.edu.agh.cast.schema.util.Messages.ShowPropertiesAction doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class pl.edu.agh.cast.ui.wizards.GetSelectMediatorsParametersWizard implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 36-99 |